RBT-928 pass through jakarta annotations#116
Conversation
This reverts commit dc120e4.
…ry-2 # Conflicts: # graphql-builder/src/main/java/com/phocassoftware/graphql/builder/DirectivesSchema.java # graphql-builder/src/main/java/com/phocassoftware/graphql/builder/MethodProcessor.java # graphql-builder/src/test/java/com/phocassoftware/graphql/builder/JakartaValidationDirectiveTest.java # graphql-builder/src/test/java/com/phocassoftware/graphql/builder/type/directive/Cat.java # pom.xml
…ry-2 # Conflicts: # graphql-builder/pom.xml # graphql-builder/src/test/java/com/phocassoftware/graphql/builder/DirectiveTest.java
…h-jakarta-annotations-try-2 # Conflicts: # graphql-builder/pom.xml
ashley-taylor
left a comment
There was a problem hiding this comment.
looks good. Just a version went backwards
graphql-builder/pom.xml
Outdated
| <junit.jupiter.version>5.12.2</junit.jupiter.version> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <jackson.version>2.19.0</jackson.version> | ||
| <graphql.version>22.0</graphql.version> |
There was a problem hiding this comment.
version gone done to 22 from 24
There was a problem hiding this comment.
Yes, unfortunately the graphql-java-extended-validation library has not released support for graphql 24 yet.
There was a problem hiding this comment.
Their readme says "use 22.0 or above for graphql-java 22.x and above"
There was a problem hiding this comment.
This is the issue I am running into: graphql-java/graphql-java-extended-validation#103
There was a problem hiding this comment.
May have to be an open source developer and submit a PR up stream to add support for graphql 24
There was a problem hiding this comment.
I guess now we wait graphql-java/graphql-java-extended-validation#112
This reverts commit 8208742. # Conflicts: # graphql-builder/pom.xml
…h-jakarta-annotations-try-2
This PR hopes to add Jakarta validation to the graphql builder library.
.validate()flag is called on the schema builder.